Skip to content

Revert "Add dark mode" #1097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2019
Merged

Revert "Add dark mode" #1097

merged 1 commit into from
Dec 12, 2019

Conversation

Aloso
Copy link
Contributor

@Aloso Aloso commented Dec 11, 2019

Revert "Add dark mode"

This reverts commit 6ad1467.

Fixes #1096

This reverts commit 6ad1467.
@Aloso
Copy link
Contributor Author

Aloso commented Dec 11, 2019

Explanation:

The CSS in newsletters is inlined automatically. However, this doesn't work for rules in @media blocks, so they stay in the <style> tag and end up having a lower specificity than everything else.

This could be solved by adding !important to every rule in @media blocks. I'd be happy to do this if that's okay.

@nasa42
Copy link
Member

nasa42 commented Dec 12, 2019

I wonder if adding !important would have any side effects, e.g., if the dark mode is always the picked theme. Worth trying if you're willing to! 👍

@nasa42 nasa42 merged commit d9b0cb2 into rust-lang:master Dec 12, 2019
@Aloso
Copy link
Contributor Author

Aloso commented Dec 12, 2019

@nasa42 adding !important within a @media block doesn't have side effects. If the dark theme is disabled or unsupported, the @media block is ignored entirely.

@Aloso Aloso deleted the fix-dark-theme branch December 12, 2019 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email is unreadable with dark mode
2 participants